-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Another desperate try to fix the CI #4489
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code-wise, I think it looks good! Can't say anything about the compiler supports.
Just one question: When disabling lints, do you have a norm to give a reasoning on why some lints are disabled? I find that it helps to have some comment next to the NOLINT
statement to remind me when I inevitable forget why I disabled this lint.
Thanks!
Yes, I agree. There are 134 |
I merge this now. Good is better than perfect... |
This PR fixes a lot of warnings from Clang-Tidy (or suppresses them in case of false positives). Furthermore, GitHub actions have been updated.
Details:
Clang-Tidy warnings
The following warnings are currently suppressed to have a green CI. They need to be addressed at some point:
Suppressed the following warnings:
Update GitHub actions
actions/upload-artifact@v4
,actions/checkout@v4
,github/codeql-action/init@v3
,peaceiris/actions-gh-pages@v4
macos-11
image; the following Xcode versions are no longer tested in the CI: '11.7', '12.4', '12.5.1', '13.0'macos-13
image to test Xcode versions '14.2', '14.3', '14.3.1', '15.0.1', '15.1', '15.2'macos-14
image to test Xcode versions '15.3', '15.4'macos-15
image to test Xcode versions '16.0', '16.1'json-ci
image as these versions are no longer work on the respectivegcc
images (checkout fails)